Skip to content

[Feature Request] Check if PR description exists #45

Closed

Description

@anthonyma94

Hi, I'm wondering if there can be a boolean flag to check if a PR description exists. I'd like to be able to check if a description exists given a specific pattern for PR title :)

Activity

  1. gilbertsoft commented on Aug 13, 2021

    @gilbertsoft
    Member

    @anthonyma94 can you please provide some more information, I don't fully understand what you are trying to achieve. Some examples may be good...

  2. anthonyma94 commented on Aug 13, 2021

    @anthonyma94
    Author

    Sorry about that, I'll include some examples:

    This is valid since there is text in the description
    image

    This is invalid since there is no text in the description
    image

    Currently if the second PR is submitted and the excludeTitle flag is true, the action succeeds with the message No commits found in the payload, skipping check.

  3. gilbertsoft commented on Aug 13, 2021

    @gilbertsoft
    Member

    If you like to enforce a description something like this may do it:

    "$.+\n\n.+"

    Does this help or do you still need something else?

  4. anthonyma94 commented on Aug 16, 2021

    @anthonyma94
    Author

    Unfortunately that doesn't work. If the description is empty while the excludeTitle flag is set to true, the action skips any checks and displays No commits found in the payload, skipping check.

  5. gilbertsoft commented on Aug 17, 2021

    @gilbertsoft
    Member

    Unfortunately that doesn't work. If the description is empty while the excludeTitle flag is set to true, the action skips any checks and displays No commits found in the payload, skipping check.

    Why do you need to set excludeTitle at all? And did you set excludeTitle to true? Without only the PR descriptioin is takken into account.

    grafik

  6. anthonyma94 commented on Aug 17, 2021

    @anthonyma94
    Author

    I wanted to check for description based on the title regex. Do you have any suggestions for that?

  7. locked and limited conversation to collaborators on Mar 6, 2022
  8. converted this issue into a discussion #65 on Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions