Repository navigation
Report 4.2.0 from QueryPath::VERSION and deprecate the version constants - #111
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
============================================
+ Coverage 90.69% 90.87% +0.18%
- Complexity 1424 1425 +1
============================================
Files 25 25
Lines 3170 3167 -3
============================================
+ Hits 2875 2878 +3
+ Misses 295 289 -6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
VERSION and VERSION_MAJOR were left at 3.2.2 and 3 through the whole 4.x line. Set them to the latest release, deprecate them in favour of Composer's InstalledVersions API, and add tests that tie VERSION to the newest release heading in CHANGELOG.md so they cannot drift again. Add the missing 4.2.0 changelog section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gravitypdf-bot
force-pushed
the
fix/issue-83
branch
from
October 26, 2026 00:43
56af07e to
d3988e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QueryPath::VERSIONandVERSION_MAJORwere never bumped after 3.2.2, so aVERSION_MAJOR >= 4check fails on every 4.x install.Changes
@deprecatedin favour of\Composer\InstalledVersions::getPrettyVersion('gravitypdf/querypath')(Composer 2). They are kept, so nothing breaks, and removal can wait for 5.0.# 4.2.0section toCHANGELOG.md(PHP 8.5 support, PHP 8.5 support #64). The 4.2.0 release had no changelog heading.Tests
Two new tests in
tests/QueryPath/QueryPathTest.php:testVersionMajorMatchesVersion:VERSION_MAJORequals the major part ofVERSION.testVersionMatchesLatestChangelogRelease:VERSIONequals the newest# X.Y.Zheading inCHANGELOG.md. It fails onmain('3.2.2'vs'4.2.0').Full suite,
lintandlint:min-phppass.For the maintainer
VERSIONstill has to be bumped by hand on each release. There's no release checklist or release workflow in the repo to record this in. The changelog test does enforce it: once# Unreleased changesis renamed to the new version, CI fails untilVERSIONmatches. It can't catch a tag pushed without that changelog rename.VERSION_MAJOR === 3) will now take the other branch.Fixes #83.
🤖 Generated with Claude Code