Repository navigation
Throw a QueryPath\Exception from filterLambda()/eachLambda() on PHP 8 - #110
Merged
Merged
Conversation
create_function() was removed in PHP 8.0, so both methods failed with an Error about an undefined function. They now throw an exception naming filterCallback() / each() as the replacement, and keep working on PHP 7. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #110 +/- ##
============================================
+ Coverage 90.69% 90.76% +0.07%
- Complexity 1424 1426 +2
============================================
Files 25 25
Lines 3170 3174 +4
============================================
+ Hits 2875 2881 +6
+ Misses 295 293 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filterLambda()andeachLambda()callcreate_function(), which was removed in PHP 8.0, so on PHP 8+ they die with anErrorthat doesn't name a replacement:Changes
function_exists('create_function')before doing anything and, when it's missing, throw aQueryPath\Exceptionthat names the replacement (filterCallback()/each()). Nothing changes on PHP 7.1–7.4.@deprecateddocblocks now say that the methods only work on PHP 7 and will be removed in 5.0.Tests
DOMQueryTest::testFilterLambdaandtestEachLambdaare no longer skipped unconditionally. Wherecreate_function()exists they assert the old results; where it doesn't, they expect the new exception and message. Both fail on PHP 8.5 without the fix (anErroris thrown instead). The PHP 7.4 path was checked by hand, because the localvendor/is built for PHP 8; CI covers 7.1–7.4.Behaviour change: on PHP 8+ the thrown type goes from
ErrortoQueryPath\Exception, so these calls can now be caught withcatch (QueryPath\Exception $e).Fixes #81.
🤖 Generated with Claude Code