Repository navigation
Fix not() keeping SplObjectStorage nodes instead of removing them - #106
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
============================================
+ Coverage 90.69% 90.78% +0.09%
Complexity 1424 1424
============================================
Files 25 25
Lines 3170 3170
============================================
+ Hits 2875 2878 +3
+ Misses 295 292 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not()given anSplObjectStoragekept only the nodes in the storage, because its branch was missing the negation the array andDOMElementbranches have.Change: negate the
offsetExists()check inQueryFilters::not().Tests:
DOMQueryTest::testNotRemovesTheSameNodesForEveryArgumentTypechecks that a selector, an array, anSplObjectStorageand aDOMElementdrawn from the same document (viabranch()) all remove the same nodes. TheSplObjectStorageassertion fails without the fix.Behaviour change: code passing an
SplObjectStoragetonot()and relying on the old intersection result will now get the complement.Fixes #75.
🤖 Generated with Claude Code