[gravitypdf-bot]

Fixes #98

Problem

attr(), addClass(), removeClass(), css(), hasClass(), hasAttr() and removeAttr() called element-only DOM methods on every match. When a match set contained a text, comment, CDATA or processing-instruction node, as contents() returns, they died with errors such as Call to undefined method DOMText::hasAttribute().

Fix

Following commit 745a4e2, this is fixed once in DOM rather than with a guard in each method. Two new protected helpers:

• elements() yields only the element matches, in document order. It's a generator, so it builds no array, and hasClass()/hasAttr() still stop at the first decisive element.
• firstElement() returns the first match if it's an element, and null otherwise, including for an empty set.

Every method that needs an element now goes through one of them:

Method	Helper
attr(), addClass(), removeClass(), css()	elements() / firstElement()
hasClass(), hasAttr(), removeAttr()	elements()
tag(), which #101 fixed with its own inline check	firstElement()
first(), last(), which had their own nodeType check	elements()

Behaviour (as in jQuery)

• Setters (attr($name, $value), attr(array), addClass(), removeClass(), the css() setter, removeAttr()) skip non-element nodes and still return the query object.
• Getters (attr($name), attr(), and css() through attr('style')) read the first node in the set. If it isn't an element they return null, the same as for an empty set. Previously, attr() with no arguments warned and returned [] in that case.
• attr('nodeType') still reports the first node's type even when it isn't an element. It never crashed, and it's a legitimate question to ask of a text node.
• hasClass() is true if any element has the class.
• hasAttr() keeps its documented "all matches have the attribute" meaning, now counted over elements only. Changing it to "any" would be a separate behaviour change.
• dataURL() and val() go through attr(), so they're fixed too.
• tag(), first() and last() behave exactly as before.

Tests

nonElementMatchSetProvider() builds five match sets: a text, comment, CDATA or PI node before an <a> element, and the element followed by all four kinds. A shared contentsWithElement() helper returns each set's contents() and its <a> element. Six tests run over the provider:

• Four new tests for attr(), addClass(), hasAttr() and other attribute/class methods fatal on non-element nodes in the match set #98, one each for attr(), css(), the class methods, and hasAttr()/removeAttr(). They check each getter's return value, that each setter returns the query object, and that the element's attributes really changed. All 20 cases error on main.
• testFirstAndLastWithNonElementNodes (new): both methods return the <a> element. It passes on main too, since their behaviour hasn't changed; it pins the refactor.
• testTagFirstMatchOfContents (from Return '' from tag() when the first match is not an element #101): now runs over the shared provider in place of its own smaller one, which gains a CDATA case.

Rebased on main. The full suite (441 tests) passes locally, and CI passes on PHP 7.1–8.5 along with composer run lint and composer run lint:min-php.

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.69%. Comparing base (c05cdac) to head (6ae6acf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #105      +/-   ##
============================================
+ Coverage     90.55%   90.69%   +0.13%     
+ Complexity     1425     1424       -1     
============================================
  Files            25       25              
  Lines          3166     3170       +4     
============================================
+ Hits           2867     2875       +8     
+ Misses          299      295       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.