Skip to content

Add the session operations for taking back, dropping and restoring interactions - #4868

Merged
TrueDoctor merged 1 commit into
masterfrom
graph-storage-11-session-ops
Oct 31, 2026
Merged

TrueDoctor merged 1 commit into
masterfrom
graph-storage-11-session-ops

Conversation

@TrueDoctor

Copy link
Copy Markdown
Member

No description provided.

@TrueDoctor
TrueDoctor added this pull request to stack #4870 October 30, 2026 22:01

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Confidence score: 3/5

  • The new GC-root set in document/graph-storage/src/session.rs isn’t used by resource GC, so retracted resources can be evicted. Route Gdd::all_referenced_resource_hashes or its caller through Session::resource_gc_roots.

You’re at about 97% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="document/graph-storage/src/session.rs">

<violation number="1" location="document/graph-storage/src/session.rs:984">
P2: The new GC-root set is never used by the actual resource-GC path. Route `Gdd::all_referenced_resource_hashes` or its caller through `Session::resource_gc_roots`, otherwise retracted resources can be evicted.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread document/graph-storage/src/session.rs Resolved
@TrueDoctor
TrueDoctor force-pushed the graph-storage-11-session-ops branch from 34f7354 to 04c1dbf Compare October 31, 2026 15:37
@TrueDoctor
TrueDoctor merged commit dc8cf0d into master Oct 31, 2026
13 checks passed
@TrueDoctor
TrueDoctor deleted the graph-storage-11-session-ops branch October 31, 2026 15:48
@TrueDoctor TrueDoctor mentioned this pull request Oct 31, 2026
6 of 51 tasks

This branch was successfully deployed

1 active deployment
graphite-dev (Preview) — 04c1dbf9 Deployed Oct 31, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant