Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses one of #6712 TO-DO list:
[{dialog:a_dialog, ...}, "geyser:another_dialog"], leading to heterogeneous lists.Changes
– Added an internal
HolderEntry(Directfor inline values,Idfor network IDs) inGeyserHolderSetso mixed lists maintain their original sequence.– Implemented ordered resolution in
resolve(session)for mixed entries.– Made
TagCache#isdelegate toGeyserHolderSet#containsto avoidIllegalStateExceptionon inline/mixed sets.– Added unit tests in
GeyserHolderSetTestcovering all variants (empty, tag, single string, single inline, homogeneous lists, and mixed lists).Testing
– Ran all 7 test cases in
GeyserHolderSetTest(passed).– Ran the full
:core:testsuite (passed).– Tested on Paper 26.3-35-main@dd9d103 with Bedrock player joining and playing cleanly with Floodgate.