Fix geyser connection timeout caused by translation expansion - #6579
Open
cranberry3148 wants to merge 7 commits into
Open
cranberry3148 wants to merge 7 commits into
cranberry3148 wants to merge 7 commits into
Conversation
cranberry3148
marked this pull request as draft
July 30, 2026 21:09
cranberry3148
marked this pull request as ready for review
July 30, 2026 21:35
Member
|
Hello! Thanks for the PR. Wouldn't this not already be covered by this addition to the flattener? |
Author
|
Hi! The linked nestingLimit line only limits recursion depth and not exponential breadth. Simply lowering that below 13 (which my testing crash item uses) would break legit detailed names, the check in this PR catches excessive expansion before flattening. |
|
Can confirm this fixes the sword crash. |
cranberry3148
force-pushed
the
fix/prevent-translation-amplification
branch
from
August 4, 2026 20:44
71178c4 to
0c54127
Compare
cranberry3148
force-pushed
the
fix/prevent-translation-amplification
branch
from
August 22, 2026 22:11
0c54127 to
cc39492
Compare
Author
|
Hey! I removed the recursive pre-scan, moved the cap into complexMapper, and added a regression test for wide, non-amplifying translations. |
cranberry3148
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent potential DoS attacks by capping how much a translatable message can expand during rendering. Introduce an amplification calculation and reject overly complex messages.
(Written by Codex, tested by Humans)