Skip to content

Localize incremental sync UI strings and update interval settings - #3

Merged
GetLogBy merged 2 commits into
mainfrom
dev
Aug 15, 2026
Merged

GetLogBy merged 2 commits into
mainfrom
dev

Conversation

@GetLogBy

Copy link
Copy Markdown
Owner

No description provided.

- 间隔档位改为 即时(0)/5/10/30 分钟,默认 5 分钟
- WorkManagerHelper 双路径调度:>=15min 走 PeriodicWorkRequest,
  <15min(即时/5/10)用 OneTimeWorkRequest 自续期循环
- SyncWorker 同步成功后 scheduleNext 续排下一轮,即时模式连续同步
- 更新四语言字符串与设置默认值
@GetLogBy
GetLogBy merged commit 1aa8c64 into main Aug 15, 2026
2 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8c3f14a325

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

ExistingPeriodicWorkPolicy.UPDATE,
wm.enqueueUniqueWork(
UNIQUE_LOOP,
ExistingWorkPolicy.REPLACE,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid replacing the running loop worker

When the selected interval is Immediate/5/10 minutes, the worker that calls scheduleNext() is still the unfinished unique work named sync_loop_work. Enqueuing the next request with ExistingWorkPolicy.REPLACE cancels any unfinished work with that same name, so each successful loop iteration cancels the currently returning worker instead of just scheduling after it; app/start rescheduling can also stop an in-flight loop sync. Use a non-canceling chain policy or a separate request name so the active sync is allowed to finish cleanly.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant