perf: limit embedded browser renderer processes - #274
Open
livvaa wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small and low-risk, with only a minor documentation wording concern noted.
Pull request overview
This PR reduces idle memory usage in SyncTrayzor’s embedded CefSharp browser by limiting Chromium’s renderer process count, which aligns with the app’s single embedded browser usage.
Changes:
- Adds a Chromium command-line switch to cap renderer processes at 1.
- Minor formatting/whitespace adjustment at the end of
ViewerViewModel.cs.
File summaries
| File | Description |
|---|---|
| src/SyncTrayzor/Pages/ViewerViewModel.cs | Adds renderer-process-limit=1 to CefSharp initialization to reduce idle renderer overhead. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+163
to
+164
| // SyncTrayzor hosts a single trusted local page. Chromium otherwise keeps a spare renderer | ||
| // around, which adds roughly 50 MiB of idle memory without benefiting this single-view app. |
Owner
|
I'll have to give this some more testing, but on first look this looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
dotnet test src -c Release --no-restore