build: update bundled Syncthing to v2.1.3 - #273
Open
livvaa wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new version-detection logic relies on brittle token-splitting and should be made robust to avoid incorrect version parsing and unnecessary re-downloads.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the build tooling to bundle Syncthing v2.1.3 and improves the Windows download/extract script to better handle existing downloads and extraction layout.
Changes:
- Bumps the configured Syncthing download version from v2.0.3 to v2.1.3.
- Updates the download script to detect an already-downloaded Syncthing binary and replace it when the version differs.
- Changes extraction handling to copy/merge extracted contents into the target directory (instead of moving), preserving existing nested files.
File summaries
| File | Description |
|---|---|
| Taskfile.yml | Updates the pinned bundled Syncthing version to v2.1.3 for build tasks. |
| scripts/download-syncthing.ps1 | Adds version-aware “already downloaded” handling and switches extracted-content promotion from move to copy/merge. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+9
to
+10
| $versionOutput = & "$outdir/syncthing.exe" version 2>$null | Select-Object -First 1 | ||
| $currentVersion = ($versionOutput -split '\s+')[1] |
Comment on lines
45
to
+48
| # Optionally move binaries up from the nested folder | ||
| $extractedRoot = Join-Path $outdir "syncthing-windows-$arch-$Version" | ||
| if (Test-Path $extractedRoot) { | ||
| Move-Item -Path (Join-Path $extractedRoot '*') -Destination $outdir -Force | ||
| Copy-Item -Path (Join-Path $extractedRoot '*') -Destination $outdir -Recurse -Force |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
dotnet test src -c Release --no-restore