Swap the order in which ghostscript is found on Windows#9019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows we ship a gs executable and and a gs dll together with our own binaries and this is detected automatically by psconvert. However, if other fonts are need I think they wont be found (not sure of this but I have distant recalls of issues of this kind for asian users). This PR changes the order by which ghostscript is searched on Windows. Now it searches first for an official installed Ghostscript (via Windows registry) and only if it fails to find one the default that we ship will be used. This has the further advantage of giving users the choice of what GS version to use.