Hopefully fix sounds leak#193
Merged
Merged
Conversation
|
Here's my proposed fix, which should be more resilient in theory: MightyPirates@e9cb3d4 Could you please take a look? I've been long out of the modding game... but I typically tackled this kind of problem with WeakRefs. |
Member
Author
this looks fine |
Alexdoru
force-pushed
the
alex/fix-soundl-eak
branch
from
3f3eca4 to
23377db
Compare
PLASMAchicken
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry picked fixed from upstream mentionned in comment