Skip to content

fix: clarify Redis TagAware check targets HTTP cache only (#245)#447

Merged
shyim merged 3 commits into
FriendsOfShopware:mainfrom
roboshyim:fix/245-redis-tag-aware-message
Jul 23, 2026
Merged

fix: clarify Redis TagAware check targets HTTP cache only (#245)#447
shyim merged 3 commits into
FriendsOfShopware:mainfrom
roboshyim:fix/245-redis-tag-aware-message

Conversation

@roboshyim

Copy link
Copy Markdown
Contributor

Summary

Fixes the confusing UX around #245.

Background

RedisTagAwareChecker has always inspected cache.http only (as @tinect noted). The reporter’s config intentionally keeps cache.object on plain Redis while using TagAware elsewhere. The warning label still read:

Redis adapter should be TagAware

…which looks like a global/object-cache problem even when cache.http is the only pool under scrutiny.

Changes

  • Result snippet → HTTP cache (cache.http) Redis adapter should be TagAware
  • Show the actual detected type as current (includes Redis version when available)
  • Skip cleanly if cache.http is not registered
  • Admin recommendation modal: explicit “this is not about cache.object” + example YAML that keeps plain Redis for object cache
  • Unit tests for missing pool / TagAware / plain Redis / filesystem

Out of scope

Changing which pool is checked (still HTTP cache — that remains the correct production recommendation). No behaviour change for shops already on TagAware HTTP cache.

Test plan

  • Standalone unit assertions against the checker (9/9)
  • CI phpunit on PR

…hopware#245)

The performance checker always inspected cache.http, but the table label
read like a global Redis warning — misleading when cache.object is
intentionally plain Redis (see FriendsOfShopware#245).

- Rename result snippet to mention HTTP cache (cache.http)
- Guard missing cache.http pool
- Expand Admin recommendation copy + example config
- Add unit tests covering TagAware / plain Redis / non-Redis / missing pool
@greptile-apps

greptile-apps Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the Redis TagAware health check to explicitly target cache.http.

  • Skips the check when the HTTP cache pool is unavailable.
  • Reports the detected Redis adapter type and version.
  • Clarifies the administration recommendation and preserves plain Redis for cache.object in the example.
  • Adds unit coverage for missing, TagAware, plain Redis, and non-Redis HTTP cache configurations.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failures remain.

Important Files Changed

Filename Overview
src/Components/Health/Checker/PerformanceChecker/RedisTagAwareChecker.php Narrows the warning text to the HTTP cache, safely handles a missing pool, and reports the detected adapter type.
src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-index/recommendations.js Clarifies the recommendation scope and provides an HTTP TagAware configuration example with an optional plain Redis object cache.
tests/Components/Health/Checker/PerformanceChecker/RedisTagAwareCheckerTest.php Adds focused regression coverage for the checker's supported cache-pool and adapter states.

Reviews (3): Last reviewed commit: "fix: code-style" | Re-trigger Greptile

PHPStan notIdentical.alwaysTrue: after the early return, $httpCacheType
always starts with TYPE_REDIS so !== '' is redundant.
@shyim

shyim commented Jul 23, 2026

Copy link
Copy Markdown
Member

@frosh-ci fix-cs

@frosh-automation

Copy link
Copy Markdown
Contributor

Code style has been fixed and pushed to the branch.

@shyim
shyim merged commit b6708bd into FriendsOfShopware:main Jul 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants