Feat: see all performance settings / toggle done settings#384
Feat: see all performance settings / toggle done settings#384zukucker wants to merge 13 commits into
Conversation
schneider-felix
left a comment
schneider-felix
left a comment
There was a problem hiding this comment.
Looks good to me.
I think it could be a bit better if you refactored the checkers a bit. Instead of adding an else clause to each checker, I would add a new static function to SettingsResult.
Theoretically you could also add a constructor to SettingsResult, but that would be a breaking change and I know that there are people who use this class in their plugins.
So I would do it like this:
Add a new static function SettingsResult::create() which takes the same parameters as the other static functions but also additionally takes the state as the first parameter. With that, you can simply remove the if-else clause from the checkers and use the SettingsResult::create() function instead.
|
Hi, thank you - way better solution. You are absolute right. ill do it asap 👍 |
| <template v-slot:header-right> | ||
| <sw-switch-field | ||
| v-model:value="showDone" | ||
| label="Erledigte anzeigen" |
There was a problem hiding this comment.
You should use a snippet here :)
|
@claude can you take over this branch and fix conflicts |
|
Should i carry on with the snippet / conflicts? |
a448fc7 to
c996914
Compare
Greptile SummaryThis PR adds completed performance settings to the health view. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (3): Last reviewed commit: "fix: address review findings" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
# Conflicts: # src/Components/Health/Checker/PerformanceChecker/CompressionMethodChecker.php # src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-index/index.js # src/Resources/app/administration/src/module/frosh-tools/component/frosh-tools-tab-index/template.twig
- restore error severity for group_concat_max_len check - show actual increment storage backend values instead of recommended text - skip sql_mode/timezone rows when the value cannot be read - type SettingsResult::create() state with class constants
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
======================================
Coverage ? 8.30%
Complexity ? 1366
======================================
Files ? 101
Lines ? 4298
Branches ? 0
======================================
Hits ? 357
Misses ? 3941
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 participants
Hey,
tried my best to implement a solution for #360 .
Please let me know if if i can do anything better.