Repository navigation
[2.x] chore: update dev dependencies for Flarum 2.0.0 - #129
Merged
Merged
Conversation
Require flarum/phpstan ^2.0.0 instead of 2.x-dev (v2.0.0 keeps Larastan below 3.12), drop flarum/core 2.x-dev from require-dev so dev installs test against the 2.0.0 release, and update flarum-webpack-config to ^3.0.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue: Flarum 2.0.0 is out.
Changes proposed in this pull request:
flarum/phpstan:2.x-dev→^2.0.0. The2.x-devpin from [2.x] chore: require flarum/phpstan 2.x-dev #120 worked around Larastan 3.12+. flarum/phpstan v2.0.0 keeps Larastan below 3.12 (it resolves 3.11.0), so the stable release is enough.flarum/coreremoved fromrequire-dev.requirealready asks for^2.0.0, so dev installs and CI test against the released 2.0.0 rather than the 2.x branch head.flarum-webpack-config:^3.0.2→^3.0.6, the current release.yarn.lockis updated for it; the build-only packages it depends on, mostly Babel, were re-resolved.requireis unchanged: it already asks forflarum/core: ^2.0.0.Confirmed
yarn check-typings,yarn format-checkandyarn buildpass.composer test: 81 unit, 70 integration), andcomposer analyse:phpstanpasses.