Adopt jspecify + NullAway null-checking on fdb-relational-jdbc - #4533
Draft
arnaud-lacurie wants to merge 1 commit into
Draft
Conversation
Companion change to the fdb-relational-grpc null-checking adoption, stacked on that branch. Same treatment: jspecify + NullAway wired via net.ltgt.errorprone, scoped to this module only; the com.apple.foundationdb.relational.jdbc package is marked @NullMarked; javax.annotation.Nonnull/Nullable usages replaced with jspecify's @nullable. Compiling with NullAway surfaced several previously undocumented nullable fields/returns (JDBCRelationalConnection's serverConnection/ closeable/schema, JDBCRelationalStatement's currentResultSet, StatefulServerConnection's requestSender) and one latent bug: schema being null (no schema set yet) was passed straight into a protobuf StatementRequest/InsertRequest builder that expects a String, which would have NPE'd inside protobuf rather than failing clearly at the call site; now coerced to "" explicitly at all four call sites. executeGet/executeScan keep their existing (pre-jspecify) @SpotBugsSuppressWarnings("NP_NONNULL_RETURN_VIOLATION") — they genuinely violate the @nonnull contract of RelationalDirectAccessStatement today, "temporary until implemented"; adding jspecify @nullable there would conflict with the @nonnull declared on the interface they override, so NullAway is suppressed at the same two sites with the same justification instead.
arnaud-lacurie
commented
Aug 28, 2026
arnaud-lacurie
left a comment
arnaud-lacurie
left a comment
Collaborator
Author
There was a problem hiding this comment.
Inline notes for the jspecify + NullAway findings mentioned in the PR description.
| .setSql(sql) | ||
| .setDatabase(getDatabase()) // TODO: for transactional execution these are not required | ||
| .setSchema(getSchema()) | ||
| .setSchema(Objects.requireNonNullElse(getSchema(), "")) |
Collaborator
Author
There was a problem hiding this comment.
Latent bug caught by NullAway: schema is null before one is set, but was being passed straight into a protobuf builder's setSchema(String), which NPEs on null input. Coerced to "" here and at the other three call sites (below, and in JDBCRelationalStatement) rather than deep inside generated protobuf code.
| .setDataResultSet(TypeConversion.toResultSetProtobuf(data)) | ||
| .setDatabase(getDatabase()) | ||
| .setSchema(getSchema()) | ||
| .setSchema(Objects.requireNonNullElse(getSchema(), "")) |
Collaborator
Author
There was a problem hiding this comment.
Same null-schema-into-protobuf-setter fix as above.
| .setKeySet(TypeConversion.toProtobuf(keySet)) | ||
| .setDatabase(this.connection.getDatabase()) | ||
| .setSchema(this.connection.getSchema()) | ||
| .setSchema(Objects.requireNonNullElse(this.connection.getSchema(), "")) |
Collaborator
Author
There was a problem hiding this comment.
Same null-schema-into-protobuf-setter fix as in JDBCRelationalConnection.
| .setKeySet(TypeConversion.toProtobuf(keySet)) | ||
| .setDatabase(this.connection.getDatabase()) | ||
| .setSchema(this.connection.getSchema()) | ||
| .setSchema(Objects.requireNonNullElse(this.connection.getSchema(), "")) |
Collaborator
Author
There was a problem hiding this comment.
Same null-schema-into-protobuf-setter fix, fourth and last call site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second of a two-PR stack adopting jspecify + NullAway null-checking — stacked on #4532 (
fdb-relational-grpc). Same treatment applied tofdb-relational-jdbc. See inline comments for specific findings.