Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
tsdamas
requested review from
george-bafaloukas-forgerock,
pingidentity-gaurav and
rodrigoareis
November 2, 2026 15:31
pingidentity-gaurav
approved these changes
Nov 4, 2026
pingidentity-gaurav
left a comment
Contributor
There was a problem hiding this comment.
LGTM, nice work. The unified JSON config presets plus the in-app config editor are a big improvement over the .env approach. Reviewed the description and overall structure against the existing sample app; I did not re-review the copied code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the React Native sample apps to the 1.1.0 SDK packages and adds a new PingOne DaVinci sample app.
New:
reactnative-davincisample app@ping-identity/rn-davinci1.1.0, rendering the DaVinci collector matrix natively: PingOne Forms connectors (text, password with policy rules and structured validation errors, single/multi select, checkbox, phone number, submit, flow button), toolbox connectors (agreement, FIDO2 passkeys, flow link, MFA device registration/authentication, polling, QR code, social login, rich text label), HTTP connector fields, and the SK components (skIDPsocial login,skriskPingOne Protect)..xcconfigfor local secrets, entitlements, and PrivacyInfo.All three sample apps
.envbuild-time values to the unified in-app config schema shared with the native Android and iOS sample apps: JSON presets underassets/configs/and custom configs created, edited, and persisted on device through new Configuration and Config editor screens. Invalid preset files are skipped at startup with a warning naming the offending field. The DaVinci app keeps.env/.xcconfigonly for optional build-time native credentials (social login, FIDO2 associated domain); the OIDC app drops itsreact-native-configdependency entirely.reactnative-journeygains the device authorization grant screens and QR rendering, an auth grant panel in the user profile, and reworked journey, token, and logout screens.@ping-identity/*packages are bumped from 1.0.0 to ^1.1.0..env.examplecomment.Testing