Skip to content

Update sample app with React native SDK 1.1 features(SDKS-5246) - #146

Open
tsdamas wants to merge 2 commits into
mainfrom
SDKS-5246
Open

tsdamas wants to merge 2 commits into
mainfrom
SDKS-5246

Conversation

@tsdamas

@tsdamas tsdamas commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Updates the React Native sample apps to the 1.1.0 SDK packages and adds a new PingOne DaVinci sample app.

New: reactnative-davinci sample app

  • Demonstrates PingOne DaVinci orchestration with @ping-identity/rn-davinci 1.1.0, rendering the DaVinci collector matrix natively: PingOne Forms connectors (text, password with policy rules and structured validation errors, single/multi select, checkbox, phone number, submit, flow button), toolbox connectors (agreement, FIDO2 passkeys, flow link, MFA device registration/authentication, polling, QR code, social login, rich text label), HTTP connector fields, and the SK components (skIDP social login, skrisk PingOne Protect).
  • OAuth 2.0 device authorization grant: a device authorization screen with QR code and user-code confirmation, plus an approve-device screen.
  • PingOne Protect signals are collected headlessly before the flow advances; the DaVinci entry stays disabled until Protect initialization succeeds.
  • Complete iOS and Android project scaffolding: CocoaPods through Bundler, Gradle debug-signing setup, .xcconfig for local secrets, entitlements, and PrivacyInfo.
  • README covering setup, the supported collector matrix, and known limitations, plus unit tests for the user-code extraction helper.

All three sample apps

  • Runtime SDK configuration moves from .env build-time values to the unified in-app config schema shared with the native Android and iOS sample apps: JSON presets under assets/configs/ and custom configs created, edited, and persisted on device through new Configuration and Config editor screens. Invalid preset files are skipped at startup with a warning naming the offending field. The DaVinci app keeps .env / .xcconfig only for optional build-time native credentials (social login, FIDO2 associated domain); the OIDC app drops its react-native-config dependency entirely.
  • reactnative-journey gains the device authorization grant screens and QR rendering, an auth grant panel in the user profile, and reworked journey, token, and logout screens.
  • All @ping-identity/* packages are bumped from 1.0.0 to ^1.1.0.
  • READMEs rewritten for the new configuration flow; the root README links the new DaVinci sample.
  • Small fixes: the journey approve-device screen and an OIDC .env.example comment.

Testing

  • New DaVinci app typecheck clean.
  • Ran the simple login flow on the OIDC, Journey, and DaVinci sample apps.
  • Created and deleted configurations through the Configuration screen.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@pingidentity-gaurav pingidentity-gaurav left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work. The unified JSON config presets plus the in-app config editor are a big improvement over the .env approach. Reviewed the description and overall structure against the existing sample app; I did not re-review the copied code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants