Repository navigation
feat(action): validate definitions before generating - #252
Merged
Merged
Conversation
Contributor
Author
|
Open question: OK to start failing consumer jobs whose definitions generate but fail validation? If not, this needs to be warn-only. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![ferrfleet-interne[bot]](https://avatars.githubusercontent.com/in/5311663?s=60&v=4){kind=small}
There was a problem hiding this comment.
e27fc0b passes definitions to the Validate step through env, which settles the earlier nit. The new commit breaks nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #121
The action now runs
generate-fixtures --validatebefore generating, so a bad definitions dir fails with the named file and problem instead of partway through generation. CI also validatesfixtures/examplesso the step is exercised.Question: a consumer definition that generates today but fails validation (duplicate package names/paths, path traversal in hooks) will now fail their job. I did not treat that as breaking since that is the point of the issue, but please confirm before merge. Auto-merge is off.