Skip to content

refactor(validate): split 1010-line validate.rs into focused submodules - #450

Merged
BryanFRD merged 1 commit into
mainfrom
refactor/validate-split-into-modules
May 18, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
refactor/validate-split-into-modules

Conversation

@BryanFRD

Copy link
Copy Markdown
Contributor

Last of the four-monolith series (#447 config, #448 git, #449 monorepo+versioning).

Split

src/validate.rs (1010 LOC) → src/validate/:

File LOC Contents
mod.rs ~99 run entry point + re-exports
source.rs ~189 FileSource trait + LocalSource / GitHubSource / GitLabSource + RemoteProvider + parse_repo_spec + load_config_from_source + parse_config_content
checks.rs ~281 All ten check_* validation passes
result.rs ~59 ValidationLevel, ValidationEntry, ValidationResult, EntryOutput
output.rs ~66 output_result, print_text_result
tests.rs ~315 Tests

Compat

All external use crate::validate::* paths preserved via re-exports. No call-site changes.

Verify

  • cargo test --bin ferrflow → 598 passed
  • cargo clippy --workspace --all-targets -- -D warnings → clean
  • cargo fmt --check → clean

Copilot AI review requested due to automatic review settings May 18, 2026 18:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@BryanFRD
BryanFRD force-pushed the refactor/validate-split-into-modules branch from f7fb193 to b21b444 Compare May 18, 2026 18:59
@BryanFRD
BryanFRD merged commit 3ebcb8a into main May 18, 2026
15 checks passed
@BryanFRD
BryanFRD deleted the refactor/validate-split-into-modules branch May 18, 2026 18:59

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: b21b444 Previous: 0b5fe57 Ratio
git_changed_files/100 80217 ns/iter (± 345)
git_changed_files/1000 631161 ns/iter (± 14395)

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants