Repository navigation
fix(cli): indent a multi-line error head below the causes - #1282
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 5, 2026 18:33
![ferrfleet[bot]](https://avatars.githubusercontent.com/in/4354888?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks correct. With continuation lines of a coded head at 4 spaces, they can no longer be mistaken for a 2-space cause line. The uncoded path already tells them apart through the Caused by: prefix. The new test covers the case, and the updated expectations match the new indent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1280
On a coded error, continuation lines of the head were indented by two spaces, the depth of the causes that follow, so a multi-line head and its first cause read as one block. Head continuations now take four spaces; causes keep two, and their own continuations four. The uncoded path already separates its causes with
Caused by:and is unchanged.The existing multi-line test now expects the deeper indent, and a new test with a two-line head followed by a cause checks they stay apart; it fails with the previous indent.