Repository navigation
fix(forge): encode the tag name in the Bitbucket refs URL - #1269
Merged
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
October 4, 2026 17:31
![ferrfleet[bot]](https://avatars.githubusercontent.com/in/4354888?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Looks correct. percent_encode_path is the same helper github.rs already uses for branch refs, and it leaves / and : unencoded, so a pkg/v1.0.0 tag builds the same URL it did before. The new test covers @, + and #.
Nit: the helper lives in config::loader_js and is shared by two forges now. Moving it into a small neutral module (for example crate::url) would read better, but it doesn't need to happen in this PR.
ferrflow Bot
added a commit
that referenced
this pull request
Oct 4, 2026
## [7.27.5] - 2026-10-04 ### Bug Fixes - fix(forge): encode the tag name in the Bitbucket refs URL (#1269)
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1268
Bitbucket Cloud
create_releaseresolved the tag with/refs/tags/{tag}built from the raw name, so a#or?coming from a customtagTemplatecut the URL short and the lookup failed. The tag now goes through the samepercent_encode_pathas the GitHub ref URL in #1267:/stays, everything outside the unreserved set is encoded, soapi@v1.0.0+build#7becomesapi%40v1.0.0%2Bbuild%237, which Bitbucket decodes back to the tag.A test with that tag checks the encoded path. It fails without the fix.