Skip to content

fix(cli): print strategy names as configured and reword the forced bump in why - #1259

Merged
BryanFRD merged 1 commit into
mainfrom
fix/why-doctor-wording
Oct 3, 2026
Merged

BryanFRD merged 1 commit into
mainfrom
fix/why-doctor-wording

Conversation

@BryanFRD

@BryanFRD BryanFRD commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Closes #1235

  • ferrflow doctor printed a declared strategy through Debug lowercased, so calver-short read calvershort. VersioningStrategy now has a Display that uses the config spelling, with a test that keeps it equal to the serde name for every variant.
  • ferrflow why printed Decision: forced bump forced for a pinned version. It now reads forced bump set with --force-version.

Two other places still build the name from Debug, and I left them alone because they are output contracts: strategy_label in src/monorepo/run/plan.rs feeds bump_type in check --json and FERRFLOW_BUMP_TYPE for hooks, and why --json carries strategy. Switching them to Display changes calvershortseq to calver-short-seq for anyone matching on it, so that deserves its own decision.

@BryanFRD
BryanFRD enabled auto-merge (squash) October 3, 2026 10:00

@ferrfleet ferrfleet Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Display impl matches the kebab-case serde spelling, and the round-trip test will catch drift. Trigger::Forced is only set when strategy_label == "forced", which comes from forced_ver_for_pkg, so "set with --force-version" is accurate.

Nit: src/monorepo/run/plan.rs:503 still builds the label with format!("{pkg_strategy:?}").to_lowercase(), so calver-short still shows as calvershort in the release plan line, in why's "Decision:" line and in the bump_type output field. Switching it to pkg_strategy.to_string() finishes what the title describes. bump_type is machine-readable though, so changing it may break consumers that match on calvershort. Doing it here or in a separate PR is your call.

@BryanFRD
BryanFRD merged commit a0f1f3d into main Oct 3, 2026
32 checks passed
@BryanFRD
BryanFRD deleted the fix/why-doctor-wording branch October 3, 2026 10:03
ferrflow Bot added a commit that referenced this pull request Oct 3, 2026
## [7.27.1] - 2026-10-03

### Bug Fixes

- fix(cli): print strategy names as configured and reword the forced bump in why (#1259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): two wording glitches in why and doctor output

1 participant