Add UUID handling support - #41
Open
BashhScriptKid wants to merge 11 commits into
Open
BashhScriptKid wants to merge 11 commits into
BashhScriptKid wants to merge 11 commits into
Conversation
![codefactor-io[bot]](https://avatars.githubusercontent.com/in/25603?s=60&v=4){kind=small}
| { | ||
| public class ChartmakerLanePlayer : MonoBehaviour | ||
| { | ||
|
|
Contributor
There was a problem hiding this comment.
An opening brace should not be followed by a blank line.
Suggested change
| AfterGroup = parent, | ||
| AfterGroupUuid = parentUuid | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
Code should not contain multiple blank lines in a row.
Suggested change
| AfterGroup = parent, | ||
| AfterGroupUuid = parentUuid | ||
| }; | ||
|
|
Contributor
There was a problem hiding this comment.
Code should not contain multiple blank lines in a row.
Suggested change
Uses UUID-keyed dictionaries instead of object references for timing data backup/restore across BPM changes. Merges with existing BPMTapper feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A supposedly breaking change, as it also changes the chart file format
UUID is seeded through metadata with salts, bounded to uint32
This should allow more robust implementation and some hard bug fixes where object references across serialisation becomes fragile