You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the reader runs and does not find required fields it should not stop, but rather set the @partial attribute and report which fields are missing. There could also be a feature which just reports which fields are missing without writing a file. See #133
Its better to write Fixes #167 in the PR, because then github automatically links the PR and closes the issue automatically as soon as the branch is merged to the default branch. I added this there so you should see the PR linked below.
@sherjeelshabih, Yeah, we can close it, I found the logger is working perfectly both in Nomad and pynxtools when running converter from jupyter lab or the command line. REader user and developer will be aware of any missing fields, groups or attributes.
@sherjeelshabih I'm not sure whether we should keep it open as we don't error out with the reader anymore but we don't implemented the part of writing the @partial attribute. I think it would be useful to denote in the produced file that this is not a valid NeXus file at least.
@sherjeelshabih I'm not sure whether we should keep it open as we don't error out with the reader anymore but we don't implemented the part of writing the @partial attribute. I think it would be useful to denote in the produced file that this is not a valid NeXus file at least.
Sorry, I did not notice it. Just a short comment on the partial attributes. Alongside with the @partial, you might also think to have the list of the missing fields on the parent data object let say under @missing_concepts. So later on without the log info, viewer or user might also get deeper info for @partial from the nexus file in any platform.
Feel free to reopen this issue as you see fit. I guess we have added functionality to pick up files with the @partial list and merge them. But this as you say is about writing out the @partial list automatically.
Activity
RubelMozumder commentedon Nov 1, 2023
PR: #175
domna commentedon Nov 1, 2023
Its better to write
Fixes #167in the PR, because then github automatically links the PR and closes the issue automatically as soon as the branch is merged to the default branch. I added this there so you should see the PR linked below.sherjeelshabih commentedon Feb 14, 2024
Can this be closed? @RubelMozumder @domna
RubelMozumder commentedon Feb 14, 2024
@sherjeelshabih, Yeah, we can close it, I found the logger is working perfectly both in Nomad and pynxtools when running converter from jupyter lab or the command line. REader user and developer will be aware of any missing fields, groups or attributes.
domna commentedon Feb 15, 2024
@sherjeelshabih I'm not sure whether we should keep it open as we don't error out with the reader anymore but we don't implemented the part of writing the
@partialattribute. I think it would be useful to denote in the produced file that this is not a valid NeXus file at least.RubelMozumder commentedon Feb 16, 2024
Sorry, I did not notice it. Just a short comment on the partial attributes. Alongside with the
@partial, you might also think to have the list of the missing fields on the parent data object let say under@missing_concepts. So later on without the log info, viewer or user might also get deeper info for@partialfrom thenexusfile in any platform.sherjeelshabih commentedon Feb 16, 2024
Feel free to reopen this issue as you see fit. I guess we have added functionality to pick up files with the @partial list and merge them. But this as you say is about writing out the @partial list automatically.
lukaspie commentedon Jan 12, 2026
Closed as
@partialis currently not accepted, we should open a new issue if/when we try to restart this idea.