Repository navigation
Fix orca - #265
Merged
Merged
Fix orca#265
Conversation
Merged
4 of 12 tasks
5 of 12 tasks
ndaelman-hu
approved these changes
Oct 9, 2026
ndaelman-hu
left a comment
ndaelman-hu
left a comment
Collaborator
There was a problem hiding this comment.
Approved. #527 merges in first, then this one. Pls, also remove the m_def.
Collaborator
|
Verified in the Area C distro with Please also add |
… TODO - `ModelMethodElectronic.relativity` is typed `RelativityModel`, so `m_def=` has no effect - the TODO asked for mapper support of the single-subsection target this PR now uses - format `get_relativity_model` signature on one line (ruff)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failed nightly test https://github.com/FAIRmat-NFDI/nomad-parser-plugins-simulation/actions/runs/37874705060/job/113640508956