Repository navigation
fix(events): make AI directives implement DirectiveInterface so they run - #3960
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3959
What
EventDateContextDirectiveandPinnedVenueContextDirectivenowimplement DirectiveInterface.PromptBuildersilently skips registered directives that don't, so until now neither had ever reached a prompt.inc/Core/EventDateContextDirective.php,inc/Core/PinnedVenueContextDirective.php) and are autoloaded when PromptBuilder resolves them.inc/Core/event-ai-directives.php. It names the classes with::classstrings, which doesn't trigger autoloading. The priorities stay at 55 and 56 in pipeline mode.Why
After #3957 deployed, the re-run Stumble Inn flow still rejected shows as
wrong_location. In production the directive returns the right text for that job's engine_data, but PromptBuilder never calls it. The #3882 date directive has been dead the same way.Tests
EventAiDirectivesPromptTestruns the realPromptBuilderwith the registered directives and asserts both appear inapplied_directivesand in the built messages.datamachine_directivesfilter registration.Written by Extra Chill Bot (AI agent) on behalf of Chris Huber.