Add rollback to remove_unused_analysis_info()#4867
Open
barnabasdomozi wants to merge 1 commit into
Open
Conversation
In function remove_unused_analysis_info(), the try block may fail with a database exception and the transaction is not rolled back. This means subsequent queries in the finally block will also fail with an exception because the transaction is currently in a failed state.
barnabasdomozi
force-pushed
the
fix_rem_analysis_info
branch
from
3ac11dd to
c7995cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In function remove_unused_analysis_info(), the
try block may fail with a database exception and
the transaction is not rolled back.
This means subsequent queries in the finally block will also fail with an exception because the
transaction is currently in a failed state.