Skip to content

fix: preserve tested_by edges for Python test files under tests/ #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sihaoqiaouzi wants to merge 1 commit into
base: main
Choose a base branch
from
+29 −4
Open

fix: preserve tested_by edges for Python test files under tests/ #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions tests/skill/understand/test_merge_batch_graphs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,29 @@ def test_python_test_files(self) -> None:
self.assertTrue(mbg.is_test_path("bar_test.py"))
self.assertTrue(mbg.is_test_path("test_bar.py"))

def test_python_tests_directory(self) -> None:
# Files under `tests/` count as tests even without a `test_` prefix or
# `_test` suffix — e.g. `tests/run_tests.py`, `tests/stage4_e2e.py`.
for path in [
"tests/run_tests.py",
"tests/stage3_tests.py",
"tests/stage4_e2e.py",
"tests/gen_data.py",
"tests/helpers.py",
]:
with self.subTest(path=path):
self.assertTrue(mbg.is_test_path(path), f"{path} should be a test")

def test_python_non_test_paths(self) -> None:
# A `tests` substring elsewhere in the path must not trigger a match.
for path in [
"data_agent/core/sqlite_utils.py",
"mypkg/testing/helpers.py",
"src/latest.py",
]:
with self.subTest(path=path):
self.assertFalse(mbg.is_test_path(path), f"{path} should NOT be a test")

def test_java_test_files(self) -> None:
self.assertTrue(mbg.is_test_path("src/test/java/com/foo/BarTest.java"))
self.assertTrue(mbg.is_test_path("src/test/java/com/foo/BarTests.java"))
Expand Down
10 changes: 6 additions & 4 deletions understand-anything-plugin/skills/understand/merge-batch-graphs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def resolve_ua_dir(root: Path) -> Path:
# These language configs treat every source file below `tests/` as part of a
# test target, even when the basename itself has no test marker. JS/TS is
# intentionally absent: files such as `__tests__/helpers.ts` remain helpers.
_TEST_DIRECTORY_EXTENSIONS: frozenset[str] = frozenset({".swift", ".rs", ".php"})
_TEST_DIRECTORY_EXTENSIONS: frozenset[str] = frozenset({".swift", ".rs", ".php", ".py"})

_EXACT_TEST_STEMS: dict[str, frozenset[str]] = {
".rb": frozenset({"spec_helper"}),
Expand Down Expand Up @@ -342,9 +342,11 @@ def _basename(path: str) -> str:
def is_test_path(path: str) -> bool:
"""Return True if `path` looks like a test file by language convention.

Most languages use basename markers. Swift, Rust, and PHP additionally
make `tests/` a test-source root. JS/TS files still require `.test` or
`.spec`, so `__tests__/helpers.ts` remains a non-test helper.
Most languages use basename markers. Swift, Rust, PHP, and Python
additionally make `tests/` a test-source root, so `tests/run_tests.py`
(no `test_` prefix, no `_test` suffix) is still recognized as a test.
JS/TS files still require `.test` or `.spec`, so `__tests__/helpers.ts`
remains a non-test helper.
"""
stem, ext = os.path.splitext(_basename(path))
ext = ext.lower()
Expand Down