Repository navigation
fix(eduide): preload the distroless oauth2-proxy image with its own binary (2.7.2) - #69
Merged
Merged
Conversation
…inary (2.7.2) The default /bin/sh -c echo init container cannot start in an image without a shell, so every preloading pod on 2.7.1 crash-looped on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 42 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Rendered diff across all environments108 lines changeddiff -ru out-base/_eduide-cluster.yaml out-head/_eduide-cluster.yaml
--- out-base/_eduide-cluster.yaml 2026-11-06 21:29:03.118932130 +0000
+++ out-head/_eduide-cluster.yaml 2026-11-06 21:29:05.399948311 +0000
@@ -4553,7 +4553,7 @@
app.kubernetes.io/part-of: eduide
app.kubernetes.io/managed-by: Helm
data:
- platformVersion: "2.7.1"
+ platformVersion: "2.7.2"
appVersion: "1.5.0"
---
# Source: eduide-cluster/templates/crds/appdefinition.yaml
diff -ru out-base/e2e.eduide.student.k8s.aet.cit.tum.de.yaml out-head/e2e.eduide.student.k8s.aet.cit.tum.de.yaml
--- out-base/e2e.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:01.781922646 +0000
+++ out-head/e2e.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:04.041938678 +0000
@@ -690,9 +690,10 @@
- name: image-preload-5
image: "quay.io/oauth2-proxy/oauth2-proxy:v7.12.0"
imagePullPolicy: Always
- command: ["/bin/sh", "-c"]
+ command:
+ - /bin/oauth2-proxy
args:
- - "echo 'Loaded image quay.io/oauth2-proxy/oauth2-proxy:v7.12.0'; exit 0"
+ - --version
# Run the pause container to make the Pod go into the Running state without consuming resources
containers:
- name: run
diff -ru out-base/eduide.artemis.cit.tum.de.yaml out-head/eduide.artemis.cit.tum.de.yaml
--- out-base/eduide.artemis.cit.tum.de.yaml 2026-11-06 21:29:02.042924498 +0000
+++ out-head/eduide.artemis.cit.tum.de.yaml 2026-11-06 21:29:04.315940621 +0000
@@ -735,9 +735,10 @@
- name: image-preload-9
image: "quay.io/oauth2-proxy/oauth2-proxy:v7.12.0"
imagePullPolicy: Always
- command: ["/bin/sh", "-c"]
+ command:
+ - /bin/oauth2-proxy
args:
- - "echo 'Loaded image quay.io/oauth2-proxy/oauth2-proxy:v7.12.0'; exit 0"
+ - --version
# Run the pause container to make the Pod go into the Running state without consuming resources
containers:
- name: run
diff -ru out-base/mannheim.eduide.aet.cit.tum.de.yaml out-head/mannheim.eduide.aet.cit.tum.de.yaml
--- out-base/mannheim.eduide.aet.cit.tum.de.yaml 2026-11-06 21:29:02.304926356 +0000
+++ out-head/mannheim.eduide.aet.cit.tum.de.yaml 2026-11-06 21:29:04.581942508 +0000
@@ -745,9 +745,10 @@
- name: image-preload-10
image: "quay.io/oauth2-proxy/oauth2-proxy:v7.12.0"
imagePullPolicy: Always
- command: ["/bin/sh", "-c"]
+ command:
+ - /bin/oauth2-proxy
args:
- - "echo 'Loaded image quay.io/oauth2-proxy/oauth2-proxy:v7.12.0'; exit 0"
+ - --version
# Run the pause container to make the Pod go into the Running state without consuming resources
containers:
- name: run
diff -ru out-base/staging.eduide.student.k8s.aet.cit.tum.de.yaml out-head/staging.eduide.student.k8s.aet.cit.tum.de.yaml
--- out-base/staging.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:02.552928115 +0000
+++ out-head/staging.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:04.834944303 +0000
@@ -690,9 +690,10 @@
- name: image-preload-5
image: "quay.io/oauth2-proxy/oauth2-proxy:v7.12.0"
imagePullPolicy: Always
- command: ["/bin/sh", "-c"]
+ command:
+ - /bin/oauth2-proxy
args:
- - "echo 'Loaded image quay.io/oauth2-proxy/oauth2-proxy:v7.12.0'; exit 0"
+ - --version
# Run the pause container to make the Pod go into the Running state without consuming resources
containers:
- name: run
diff -ru out-base/test1.eduide.student.k8s.aet.cit.tum.de.yaml out-head/test1.eduide.student.k8s.aet.cit.tum.de.yaml
--- out-base/test1.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:02.800929875 +0000
+++ out-head/test1.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:05.081946055 +0000
@@ -691,9 +691,10 @@
- name: image-preload-5
image: "quay.io/oauth2-proxy/oauth2-proxy:v7.12.0"
imagePullPolicy: Always
- command: ["/bin/sh", "-c"]
+ command:
+ - /bin/oauth2-proxy
args:
- - "echo 'Loaded image quay.io/oauth2-proxy/oauth2-proxy:v7.12.0'; exit 0"
+ - --version
# Run the pause container to make the Pod go into the Running state without consuming resources
containers:
- name: run
diff -ru out-base/test2.eduide.student.k8s.aet.cit.tum.de.yaml out-head/test2.eduide.student.k8s.aet.cit.tum.de.yaml
--- out-base/test2.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:03.050931648 +0000
+++ out-head/test2.eduide.student.k8s.aet.cit.tum.de.yaml 2026-11-06 21:29:05.330947821 +0000
@@ -691,9 +691,10 @@
- name: image-preload-5
image: "quay.io/oauth2-proxy/oauth2-proxy:v7.12.0"
imagePullPolicy: Always
- command: ["/bin/sh", "-c"]
+ command:
+ - /bin/oauth2-proxy
args:
- - "echo 'Loaded image quay.io/oauth2-proxy/oauth2-proxy:v7.12.0'; exit 0"
+ - --version
# Run the pause container to make the Pod go into the Running state without consuming resources
containers:
- name: run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart 2.7.1 (#67) added the oauth2-proxy image to image preloading, but every preload init container runs
/bin/sh -c "echo ...", and the oauth2-proxy image is distroless: it has no shell. The container fails withStartError(exit 128), and everyimage-preloadingpod on the test environments sat inInit:CrashLoopBackOff.The proxy entry now uses the template's existing per-image
command/argssupport and runs/bin/oauth2-proxy --version, which exits 0 (checked withdocker run --entrypoint /bin/oauth2-proxy quay.io/oauth2-proxy/oauth2-proxy:v7.12.0 --version; the image's entrypoint is/bin/oauth2-proxy, user 65532).scripts/test-app-consistency.shnow asserts the proxy's init container runs the binary, not a shell; it fails on 2.7.1's template. The earlier test only checked that the image was in the list, which is how this shipped.Both charts move to 2.7.2.
🤖 Generated with Claude Code