Repository navigation
Conversation
The bump check iterated charts/*/ and asked git for charts/eduide//Chart.yaml, which git rejects. Every changed chart therefore looked new and the check never failed since it was added in #23. That is how #52 merged without a bump. - ci.yml: strip the trailing slash before looking up the base version - release.yml: fail a push to main that changed a chart whose version is already published, instead of skipping it silently; Helm v3.16.3 like the other workflows - release-train.yml: fix the eduidec-landing-page typo, create a lightweight tag (git tag -a needs a committer identity), and wait for the dispatched run instead of the newest run in the repository Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Rendered diff across all environmentsNo change to any rendered manifest. For a pure refactor this is the result you want. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#52 merged with chart changes but no version bump, so its fix was on main but missing from the published chart 2.5.1. The CI step "Chart version must be bumped when a chart changes" passed.
Root cause: the loop iterates
charts/*/, sogit show "$base:$chart/Chart.yaml"asks forcharts/eduide//Chart.yaml. Git rejects the double slash,oldstays empty, and every changed chart is reported as a new chart (#52's log:eduide: new chart at 2.5.1). The check has never failed since #23 added it.What
ci.yml: strip the trailing slash before the lookup.release.yml: a push to main that changed a chart whose version is already published now fails instead of skipping silently. Helmv3.16.3, like the other workflows.release-train.yml:eduidec-landing-pagetypo, which made landing page verification impossible;git tag -aneeds a committer identity thatactions/checkoutdoes not set;Verification
732280e...9464a1c): fails for both charts. On chore(eduide): pin EduIDE-Cloud 1.2.2 (chart 2.6.2) #59: passes (2.6.1 -> 2.6.2).732280e..f9519b9): both charts changed while 2.5.1 existed, so it fails.gh run list --workflow build.yml --event workflow_dispatch --created ">=..."returns the expected run against EduIDE/EduIDE.Part of the CI alignment plan (Wave 0).
🤖 Generated with Claude Code