-
Notifications
You must be signed in to change notification settings - Fork 9
Investigate minSdk requirement #410
Copy link
Copy link
Open
1 / 11 of 1 issue completedLabels
architectureIssues/PRs related to the app's architecture.Issues/PRs related to the app's architecture.blockedIssues/PRs that are currently blocked by external factors.Issues/PRs that are currently blocked by external factors.bugBugs that have appeared in the release/ debug version of the app.Bugs that have appeared in the release/ debug version of the app.code healthIssues/PRs related to improving code quality/healthIssues/PRs related to improving code quality/healthhelp wantedIssues/ PRs that will benefit help from the community.Issues/ PRs that will benefit help from the community.questionAll questions related to the web version of the repo.All questions related to the web version of the repo.
Description
Activity
Metadata
Metadata
Assignees
Labels
architectureIssues/PRs related to the app's architecture.Issues/PRs related to the app's architecture.blockedIssues/PRs that are currently blocked by external factors.Issues/PRs that are currently blocked by external factors.bugBugs that have appeared in the release/ debug version of the app.Bugs that have appeared in the release/ debug version of the app.code healthIssues/PRs related to improving code quality/healthIssues/PRs related to improving code quality/healthhelp wantedIssues/ PRs that will benefit help from the community.Issues/ PRs that will benefit help from the community.questionAll questions related to the web version of the repo.All questions related to the web version of the repo.
Projects
- StatusShow more project fieldsBacklog
Is there an existing issue for this?
What happened?
Android Lollipop (API 21) appears to be used by 2% of devices globally according to https://apilevels.com, so I think we should be save to bump the minSdk requirement to a higher version
Currently, Jetpack Compose requires minSdk = 21+, which is what the app currently uses:
studybuddy-android/app/build.gradle.kts
Line 56 in 011cb7d
However, there's probably no real benefit in supporting such a low percentile 🤷
Expected behaviour
minSdk should be a higher version to allow for newer Android features to be used without having to backport changes (e.g. removing explicit Marshmallow checks for runtime permissions, weird behaviours on older versions), etc
Reproduction steps
N.A.
Application variant
Release, Debug, Nightly
Application version
No response
Application version code
No response
Relevant log output
No response
Possible solution
We can:
Additional context
Trying to incorporate Telephoto (image zooming composable) into the app, which requires minSdk = 23 as of 0.4.0
As a minimum I might consider bumping to
minSdk = 26, this should also remove the need to use core library desugaring