ECOM-17052 Omni Store Credit. Refund. Add order.storeCredit.refund field#554
Open
mamirovlspeed wants to merge 1 commit intomasterfrom
Open
ECOM-17052 Omni Store Credit. Refund. Add order.storeCredit.refund field#554mamirovlspeed wants to merge 1 commit intomasterfrom
mamirovlspeed wants to merge 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for the new order.storeCredit.refund field across order DTOs and the fetched→updated conversion path, ensuring nullable-property tests remain aligned with the DTO contract.
Changes:
- Added
refund: Double?toFetchedOrder.StoreCredit(result DTO). - Added
refund: Double?toUpdatedOrder.StoreCredit(request DTO) and mapped it inFetchedOrder.StoreCredit.toUpdated(). - Updated nullable-property rules to allow
FetchedOrder.StoreCredit.refundto be nullable.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/test/kotlin/com/ecwid/apiclient/v3/rule/nullablepropertyrules/FetchedOrderRules.kt | Allows the newly added StoreCredit.refund field to be nullable in DTO contract tests. |
| src/main/kotlin/com/ecwid/apiclient/v3/dto/order/result/FetchedOrder.kt | Introduces storeCredit.refund on fetched orders. |
| src/main/kotlin/com/ecwid/apiclient/v3/dto/order/request/UpdatedOrder.kt | Introduces storeCredit.refund on updated orders for write/modify flows. |
| src/main/kotlin/com/ecwid/apiclient/v3/converter/FetchedOrder.kt | Ensures refund is preserved when converting FetchedOrder.StoreCredit to UpdatedOrder.StoreCredit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
timur-efimov
approved these changes
Apr 29, 2026
Contributor
Author
|
Мерджить после https://github.com/Ecwid/ecwid/pull/14314 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.