Improve repo: fix code block ignoring and div tag parsing in rtl linter with tests - #13487
Open
vansh917917 wants to merge 1 commit into
Open
vansh917917 wants to merge 1 commit into
vansh917917 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve repo
IMPORTANT
Description
Fixes two issues in
scripts/rtl_ltr_linter.pyand adds an automated test suite:if CODE_FENCE_START.match(line): continue). Lines inside fenced blocks (```or~~~) were still evaluated as markdown list items, producing false-positive warnings on documentation files with code examples (e.g.docs/CONTRIBUTING-it.md). The linter now tracksin_code_blockstate and skips lines inside code fences.<div>Stack Synchronization: The previous tag matching could pop direction context prematurely when encountering non-directional divs (such as<div align="center">) or fail to match tags with uppercase characters or single-quoted attributes (markdown='1'). Directional context tracking is now robust against nested plain and directional tags.with open(...)) for file reads.scripts/test_rtl_ltr_linter.pycovering filename checks, span splitting, config overrides, code block ignoring, and div handling.Verification
python -m unittest discover -s scripts -v(12/12 passed).docs/CONTRIBUTING-it.md: false positives reduced from 5 to 0.Checklist: