Repository navigation
Replace datasets with glob patterns by the datasets with data - #22
Open
bouweandela wants to merge 8 commits into
Open
bouweandela wants to merge 8 commits into
bouweandela wants to merge 8 commits into
Conversation
Add a code lens above lists of datasets with glob patterns, and a code action for editors without code lenses, that replaces these datasets by the datasets that have data for every variable group that uses the list. The values are found with the facet search used for completion, and ensemble members are written as ranges with datasets_to_recipe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 93.71% 94.04% +0.33%
==========================================
Files 21 22 +1
Lines 2339 2504 +165
Branches 350 371 +21
==========================================
+ Hits 2192 2355 +163
- Misses 110 111 +1
- Partials 37 38 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Only offer the code lens and code action for ESMValTool recipes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Since the time range can be searched for, `timerange: '*'` would be replaced by a copy of the dataset for each time range found. ESMValCore resolves these patterns itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a code lens above
datasets:andadditional_datasets:lists with glob patterns, e.g.{dataset: '*', project: CMIP6, exp: historical, ensemble: 'r*i1p1f1'}, that replaces those entries by the datasets with data for every variable group that uses the list. The same command is offered as a code action on that line, for editors without code lenses such as Emacs with Eglot. Neither is offered in files that are not ESMValTool recipes.ensembleandsub_experimentare expanded last, which reduces the number of searches: all CMIP6 historicalr*i1p1f1datasets for two variables take about 40 seconds instead of 3 minutes.esmvalcore.dataset.datasets_to_recipe, and the entries are written asformat_recipewrites them. Only the entries with glob patterns are edited; anchored entries and aliases are left alone.pixi.lockonmain(forformat_recipe), sopixi.lockis updated.Known issue, not fixed here: the ESGF searches share intake-esgf's sqlite-backed requests cache between threads, and one large run logged
sqlite3.InternalError: cannot reset statement.Tested with
pixi run test,pixi run test-vscode,pixi run pre-commit run --all-files, and against ESGF.🤖 Generated with Claude Code