Repository navigation
Get the searchable facets of data sources from ESMValCore - #19
Merged
Merged
Conversation
Use DataSource.searchable_facets instead of parsing the templates of the paths of local data sources. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
==========================================
- Coverage 93.68% 93.67% -0.01%
==========================================
Files 21 21
Lines 2328 2325 -3
Branches 350 350
==========================================
- Hits 2181 2178 -3
Misses 110 110
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completion of facet values from local data sources now uses
DataSource.searchable_facetsfrom ESMValCore (ESMValGroup/ESMValCore#3261) instead of parsing the path templates of the data sources, so the facets of other kinds of data sources can also be completed. Data sources without this attribute, which are deprecated in ESMValCore, offer no facets for completion.This needs the latest
recipe-json-schemabranch of ESMValCore, sopixi.lockhas been updated. The minimum version inpyproject.tomlstays2.16.0.dev0until v2.16 is released.Tested with
pixi run testandpixi run pre-commit run --all-files.🤖 Generated with Claude Code