Support JRA55do in datm

[anton-seaice]

Description of changes

This adds support for JRA55do within datm - namely, rain and snow can be seperate forcing variables (currently assumed to be the same forcing variable)

Specific notes

Contributors other than yourself, if any:

• CDEPS Issues Fixed (include github issue #): Support JRA55do in DATM #406

Are there dependencies on other component PRs (if so list): None

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb

Any User Interface Changes (namelist or namelist defaults changes):

No namelist changes

• adds JRA55do to existing options for datamode in datm_in
• allows use of Faxa_prsn (snow) and Faxa_prrn (rain) in datm.streams.xml files

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

• We've been running ACCESS-OM3 with this change for a couple of months

Hashes used for testing:

0b2d3bd

[billsacks]

These changes basically look good to me. I appreciate your maintaining the error check with these changes.

I have one request: can you change the name of the new jra55do variable? Currently the logic that triggers this to be true will only be true for the JRA55 stream, but it seems like it could easily be true in other cases in the future, and it would be confusing to have this name in that case. Can you name it something like stream_separates_rain_snow?

[billsacks]

@mvertens - assigning you to review for approval from the NorESM side. @alperaltuntas - assigning you to review since this impacts ocean model forcing options. For both of you, feel free to reassign or remove yourself as reviewer if you want.

[anton-seaice]

Thanks @billsacks - i've made that change

[billsacks]

Better, thanks... but can you please correct the spelling? -- "seperates" should be "separates". (Sorry for the nitpick... spelling errors in variable names bug me more than they probably should.)

[mvertens]

Looks good. Thanks for the clean implementation.

[anton-seaice]

Shall I add jra55do to https://escomp.github.io/CDEPS/versions/master/html/datm.html#supported-data-modes ?

We don't use CIME, so it may not entirely make sense with the rest of the page

[billsacks]

Looks good now - thank you!

[billsacks]

Shall I add jra55do to https://escomp.github.io/CDEPS/versions/master/html/datm.html#supported-data-modes ?

We don't use CIME, so it may not entirely make sense with the rest of the page

Actually, that would be great - thanks. My sense is that that page is out of date in other respects, but whatever you can add there relatively easily would be great! I'll wait until you give me the go-ahead - for that and anything else you may want to do - before merging.