-
-
Notifications
You must be signed in to change notification settings - Fork 68
refactor: remove dead guardrails wrapper, cut redundancies, fix registry trim #449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
b306fae
refactor: remove dead guardrails wrapper, cut redundancies, fix regis…
SantiagoDePolonia 6160fc7
Merge remote-tracking branch 'origin/main' into chore-quality-improve…
SantiagoDePolonia 4a6b804
chore(guardrails): address PR review nitpicks
SantiagoDePolonia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,93 @@ | ||
| package guardrails | ||
|
|
||
| import "gomodel/internal/core" | ||
|
|
||
| // cloneToolCalls deep-copies tool calls so guardrail rewrites never mutate the | ||
| // caller's original message slice. | ||
| func cloneToolCalls(toolCalls []core.ToolCall) []core.ToolCall { | ||
| if len(toolCalls) == 0 { | ||
| return nil | ||
| } | ||
| cloned := make([]core.ToolCall, len(toolCalls)) | ||
| for i, toolCall := range toolCalls { | ||
| cloned[i] = core.ToolCall{ | ||
| ID: toolCall.ID, | ||
| Type: toolCall.Type, | ||
| Function: core.FunctionCall{ | ||
| Name: toolCall.Function.Name, | ||
| Arguments: toolCall.Function.Arguments, | ||
| ExtraFields: core.CloneUnknownJSONFields(toolCall.Function.ExtraFields), | ||
| }, | ||
| ExtraFields: core.CloneUnknownJSONFields(toolCall.ExtraFields), | ||
| } | ||
| } | ||
| return cloned | ||
| } | ||
|
|
||
| func cloneChatMessageEnvelope(message core.Message) core.Message { | ||
| return core.Message{ | ||
| Role: message.Role, | ||
| ToolCallID: message.ToolCallID, | ||
| ContentNull: message.ContentNull, | ||
| Content: cloneMessageContent(message.Content), | ||
| ToolCalls: cloneToolCalls(message.ToolCalls), | ||
| ExtraFields: core.CloneUnknownJSONFields(message.ExtraFields), | ||
| } | ||
| } | ||
|
|
||
| func cloneMessageContent(content any) any { | ||
| switch value := content.(type) { | ||
| case nil: | ||
| return nil | ||
| case string: | ||
| return value | ||
| case []core.ContentPart: | ||
| return cloneContentParts(value) | ||
| default: | ||
| parts, ok := core.NormalizeContentParts(content) | ||
| if !ok { | ||
| // Unrecognized content shapes cannot be deep-copied generically, so | ||
| // they are returned as-is. Guardrails replace whole content values | ||
| // rather than mutating them in place, so sharing the reference is | ||
| // safe; chat content is normalized to nil/string/[]ContentPart | ||
| // before reaching here, making this branch defensive. | ||
| return value | ||
| } | ||
| return cloneContentParts(parts) | ||
| } | ||
| } | ||
|
|
||
| func cloneContentParts(parts []core.ContentPart) []core.ContentPart { | ||
| if len(parts) == 0 { | ||
| return nil | ||
| } | ||
| cloned := make([]core.ContentPart, len(parts)) | ||
| for i, part := range parts { | ||
| cloned[i] = cloneContentPart(part) | ||
| } | ||
| return cloned | ||
| } | ||
|
|
||
| func cloneContentPart(part core.ContentPart) core.ContentPart { | ||
| cloned := core.ContentPart{ | ||
| Type: part.Type, | ||
| Text: part.Text, | ||
| ExtraFields: core.CloneUnknownJSONFields(part.ExtraFields), | ||
| } | ||
| if part.ImageURL != nil { | ||
| cloned.ImageURL = &core.ImageURLContent{ | ||
| URL: part.ImageURL.URL, | ||
| Detail: part.ImageURL.Detail, | ||
| MediaType: part.ImageURL.MediaType, | ||
| ExtraFields: core.CloneUnknownJSONFields(part.ImageURL.ExtraFields), | ||
| } | ||
| } | ||
| if part.InputAudio != nil { | ||
| cloned.InputAudio = &core.InputAudioContent{ | ||
| Data: part.InputAudio.Data, | ||
| Format: part.InputAudio.Format, | ||
| ExtraFields: core.CloneUnknownJSONFields(part.InputAudio.ExtraFields), | ||
| } | ||
| } | ||
| return cloned | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.