Repository navigation
fix: 새로 올린 식단의 Slack 알림 복구, 도담 휴무 문장 처리 - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
식단을 새로 올리면 Slack 알림을 다시 보냅니다. 도담 휴무 공지도 휴무로 처리합니다.
리뷰어가 할 일
functions/handler.py의newly_published_dates를 확인prod에는 이미 배포 완료
무엇이 고장났나요?
무엇을 바꿨나요?
notify_summary를true로 바꿨습니다.자세한 내용 (필요할 때만 읽으세요)
알림 규칙
10/4 조치
테스트
전체 201개가 통과합니다. 추가한 테스트는 다음과 같습니다.
배포 규칙 (PR #39와 같음)
rm -rf .aws-sam후 빌드합니다.ReservedConcurrentExecutions를 추가하지 않습니다.