Sensible download name#1256
Open
abhaysp95 wants to merge 4 commits into
Open
Conversation
added 4 commits
November 28, 2022 21:37
Author
|
The branch used to make PR sensible_download_name, is based on 234bd7a |
Contributor
|
@Docile-Alligator can you please take a look at this? |
|
I'd also like to request this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant for review purpose only as it's not complete yet
Feature Description
Allow user to toggle the setting to download the file with
sensiblefile name.What's the problem
NOTE: I'm taking the image as example for downloadable media for nowPreviously the downloaded files where stored with the format
subredditname + id, which in some cases (mentioned down below), didn't make much sense (visible in below image)What's the fix
Provide user with toggle to enable this feature
Now, the downloaded files are provided with the post title too
Why is the feature necessary
NOTE: I was not able to downloaded images from gallery post (multiple images post). Is it not implemented ?