Skip to content

base.inc: production_exception_handler improvements for TypeErrors #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cpeel merged 1 commit into from
Sep 10, 2026
Merged

base.inc: production_exception_handler improvements for TypeErrors #1639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion pinc/base.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ function production_exception_handler(Throwable $exception): void
if ($exception instanceof DBConnectionError && !$maintenance) {
// We output the timestamp in the same format and timezone (UTC) as
// the MySQL error log (sans microseconds) for easier correlation.
$error_message = gmdate("Y-m-d") . "T" . gmdate("H:i:s") . "Z " . $exception->getMessage();
$error_message = gmdate("Y-m-d\TH:i:s\Z ") . $exception->getMessage();

// Dump the error to the php error log
error_log("base.inc - $error_message");
Expand All @@ -105,6 +105,15 @@ function production_exception_handler(Throwable $exception): void
exit(1);
}

// If the exception is a TypeError, silently log the full backtrace for
// easier debugging, and continue execution.
if ($exception instanceof TypeError) {
error_log((string) $exception);
return;
}

// For all other exceptions, pretty print the exception to the HTML,
// and continue execution.
echo "<p class='error'>\n";
echo htmlspecialchars($exception->getMessage(), ENT_QUOTES, 'UTF-8');
echo "\n</p>";
Expand Down