Repository navigation
Conversation
Signed-off-by: wargloom <wargloom@gmail.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2733. With
auto_watch=true, a successfulindex_repositoryrequest from an initialized MCP session now registers the requested project and root for automatic refresh. A client started in a workspace can index a custom-named worktree and keep it fresh while that client remains connected. Previously that target reportedwatched: falsewithreason: not_session_projectafter a successful index.Track each session's memberships separately from physical watches. Shared projects remain watched until their last owner disconnects. Async completion registers a target only while a requesting session is connected; failed jobs and one-shot CLI requests do not add watches. Preserve the indexed mode and persistence option for watcher refreshes, and remove secondary watches when global
auto_watchis disabled.This uses the existing configuration and tool arguments and retains workspace-root and tool-profile checks. Update the runtime instructions, status hint, README, and configuration reference accordingly. Related: #1429, #1660.
Validation
scripts/lint.sh --ciwith Cppcheck 2.20.0,make -f Makefile.cbm lint-tidy-diff,scripts/security-audit.sh, andgit diff --check.tests/test_watcher_disabled.sh, andtests/test_worker_session_scope.shagainst the resulting binary.scripts/test.sh --suites daemon_application,sqlite_writer,mcp CC=clang CXX=clang++: 476 passed, 4 skipped. PassedASAN_OPTIONS=detect_leaks=0:detect_stack_use_after_return=0 make -f Makefile.cbm test CC=clang CXX=clang++: 9,905 passed, 9 skipped, exit 0.scripts/test.shstops at Step 0w: the published language-count check lists five surfaces with no remaining count claim (docs/index.html,docs/llms.txt,pkg/npm/README.md,scripts/package-release.sh,server.json). These files and the checker are unchanged from the base commit4cf44147. This remains a draft while the full entry point is failing.Local sanitizer builds retain two pre-existing ObjectScript scanner zero-length
memcpyguards; those changes are outside this PR. ASan/UBSan test runs disable LeakSanitizer because of the local ptrace environment.AI assistance: OpenAI Codex assisted with implementation, regression tests, documentation, and review. The submitting contributor is responsible for this change.
Checklist
git commit -s)make -f Makefile.cbm test)make -f Makefile.cbm lint-ci)