Repository navigation
Conversation
Replace legacy ESLint setup by removing .eslintrc.js and .eslintignore and adding a flat eslint.config.js that applies @wordpress/eslint-plugin recommended config with project-specific overrides and global ignores. Bump t2/t2 and related t2 packages from 8.26.0 to 8.29.0 in composer.json/composer.lock. Update Node dev tooling versions in package.json/package-lock (notable updates: @wordpress/scripts, @wordpress/dependency-extraction-webpack-plugin, autoprefixer, cssnano, dotenv, postcss, prettier, turbo and various ESLint/TypeScript related packages). Also update package.json in the block-theme package.
Composer package changes
|
There was a problem hiding this comment.
Pull request overview
Modernizes the project’s linting setup by migrating to ESLint’s flat config format and upgrades related JavaScript/PHP dependencies to newer versions.
Changes:
- Replaced legacy ESLint config files (
.eslintrc.js,.eslintignore) with a neweslint.config.jsflat config. - Upgraded JS tooling dependencies (notably
@wordpress/scriptsand related PostCSS/formatting packages) and refreshedpackage-lock.json. - Bumped
t2/t2PHP dependency to~8.29.0and updatedcomposer.lockaccordingly.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
eslint.config.js |
Introduces ESLint flat config, consolidated ignores, and project overrides. |
package.json |
Updates JS dev dependencies (including @wordpress/scripts) used by lint/build tooling. |
package-lock.json |
Locks updated dependency graph matching the upgraded toolchain. |
packages/themes/block-theme/package.json |
Aligns theme workspace tooling with updated @wordpress/scripts. |
composer.json |
Updates t2/t2 version constraint to ~8.29.0. |
composer.lock |
Reflects resolved PHP dependency updates for the new t2/t2 version. |
.eslintrc.js |
Removed legacy ESLint configuration file. |
.eslintignore |
Removed legacy ESLint ignore file (replaced by flat-config ignores). |
…ility Agent-Logs-Url: https://github.com/DekodeInteraktiv/project-base/sessions/88c93c2c-dc47-4abe-8e2c-98eee2afdfd1 Co-authored-by: olethomas <3436672+olethomas@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DekodeInteraktiv/project-base/sessions/dcf2fcd1-c25b-4fae-92c9-d56dce1b96ae Co-authored-by: olethomas <3436672+olethomas@users.noreply.github.com>
Update eslint.config.js: change the globals entry for `wp` from false to 'off' to disable that global and adjust linting behavior accordingly.
Member
Author
|
Superseeded by: #628 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's linting configuration to use the new ESLint flat config format, consolidates ignore patterns, and upgrades several dependencies for improved compatibility and features. The most important changes are grouped below:
ESLint Configuration Modernization:
.eslintrc.jsand.eslintignorefiles to the new flat config format ineslint.config.js, consolidating ignore patterns and project-specific overrides, and aligning with the latest ESLint and WordPress recommendations. ([[1]](https://github.com/DekodeInteraktiv/project-base/pull/625/files#diff-a32a0887ed9d1d707bbb3b845b7df7fd40e673c47e7b60a3ebd896b68d3b8839R1-R44),[[2]](https://github.com/DekodeInteraktiv/project-base/pull/625/files#diff-e2954b558f2aa82baff0e30964490d12942e0e251c1aa56c3294de6ec67b7cf5L1-L25),[[3]](https://github.com/DekodeInteraktiv/project-base/pull/625/files#diff-a0fdacd2ade87c5238dde44378f574f7e123e669acdf8b740878b14b33b20275L1-L6))Dependency Upgrades:
package.json, including@wordpress/scripts,autoprefixer,cssnano,dotenv,postcss,postcss-discard-comments,prettier, andturboto their latest compatible versions for improved stability and features. ([package.jsonL6-R24](https://github.com/DekodeInteraktiv/project-base/pull/625/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L6-R24))@wordpress/scriptsinpackages/themes/block-theme/package.jsonto maintain consistency across packages. ([packages/themes/block-theme/package.jsonL5-R5](https://github.com/DekodeInteraktiv/project-base/pull/625/files#diff-446c59aebd642dbfc46cfba154678b77556d45bb433031e4dacee69115b452e3L5-R5))t2/t2incomposer.jsonto version~8.29.0. ([composer.jsonL13-R13](https://github.com/DekodeInteraktiv/project-base/pull/625/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L13-R13))