coq export: check that identifiers are valid in rocq#1397
Merged
Conversation
Member
Author
|
@melanie-taprogge @agontard @navimath Do you agree with those changes? |
I agree with the changes. You are of course right that automatic renaming could introduce collisions and make names harder to trace. Fail-fast behaviour together with explicit renaming is surely the better solution. I can sure work with this solution in my translation pipeline. Thank you for looking into it Frédéric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1391. The translation of an identifier is as follows:
Hence, for instance, ε will fail, unless it is renamed to itself in the --renaming map (this works because we do not check the validity of strings to which identifiers are renamed).
Recognizing the unicode identifiers accepted by Rocq is non trivial (see https://github.com/rocq-prover/rocq/blob/master/clib/unicode.ml and https://github.com/rocq-prover/rocq/blob/master/parsing/cLexer.ml). As files do not usually contain so many unicode identifiers, asking users to declare them in --renaming seems like a good compromise.
Impact on performances:
Other changes:
TODO: