Repository navigation
[Feature] Heroic: Implement Game List queue support - #660
Merged
Merged
Conversation
Implementation of an 'Apply' button for the Heroic Games Launcher List. In current state changes made in the ComboBox are written directly to file. This could lead to several potential problems. This lines up with the practice for the Steam Game List and writes changes to a queue before applying them to the actual Heroic files.
whoops ... fixes a function that gives 4 arguments but only expects 3.
fixes some typos in previously made comments
- Show a warning listing games whose config could not be updated - Emit game_property_changed after applying so the main window refreshes - Use the combo's shown tool as the original value for games without a wineVersion Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
Thanks! I applied small improvements suggested by Claude. Otherwise, looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
since the implementation of the Heroic Game List is in the moment a bit off compared to the wonderful Steam Game List, I wrote the missing Apply-Button/ Queue-Support.
What this PR implements:
How this works:
As with the last implementation I tried to mimic the existing layout for the functions as closely as possible. The only main difference is that I ran the for-parse directly inside of PupguiGameListDialog isntead of outsourcing it to heroicutils. This can be fixed later on however.
Specs:
This PR was tested on the most recent ProtonUp-Qt branch. Feel free to merge or close it. If I messed anything up just say the word and I will get back to it :)
OS: CachyOS
ProtonUp-Qt: main branch
Heroic Games Launcher: Flatpak (v.2.22.4)