Convert createRoot to createPortal#5
Open
uzegonemad wants to merge 3 commits intoDataTables:masterfrom
Open
Conversation
Contributor
|
Many thanks for PR! I'll try to review it next week (neck deep in some other stuff, so it might take a week or two, but I'll try to get to it soon!). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR converts usage of
createRoottocreatePortal. This closes #4.I tested this with a few different datatables. In
slotRenderer, there was a previous comment about not caching orthogonal data, but everything worked fine in my testing. Please take a decent look at this to be safe.(Feel free to edit as you see fit, as well.)