add repo-specific owner overrides for injection_platform feature owner#7064
add repo-specific owner overrides for injection_platform feature owner#7064robertomonteromiguel wants to merge 2 commits into
Conversation
|
|
There was a problem hiding this comment.
Pull request overview
This PR updates the feature-owner routing for the injection_platform feature category so ownership can vary by tracer repository, rather than always defaulting to @DataDog/injection-platform. This aligns injection_platform with the existing repo_overrides pattern used for language_platform.
Changes:
- Added
repo_overridesto theinjection_platformowner definition inutils/_features.pyfor multiple tracer repositories.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| injection_platform = _OwnerDef("@DataDog/injection-platform", repo_overrides={ | ||
| "dd-trace-dotnet": "@DataDog/apm-lang-platform-dotnet", | ||
| "dd-trace-java": "@DataDog/apm-lang-platform-java", | ||
| "dd-trace-js": "@DataDog/lang-platform-js", | ||
| "dd-trace-php": "@DataDog/apm-lang-platform-php", | ||
| "dd-trace-py": "@DataDog/lang-platform-python", | ||
| "dd-trace-rb": "@DataDog/lang-platform-ruby", | ||
| }) |
There was a problem hiding this comment.
Go isn't in SSI scope yet
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ec9c12308f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "nginx-datadog": "@DataDog/apm-idm-cpp", | ||
| }) | ||
| injection_platform = _OwnerDef("@DataDog/injection-platform") | ||
| injection_platform = _OwnerDef("@DataDog/injection-platform", repo_overrides={ |
There was a problem hiding this comment.
When this runs in dd-trace-go CI, _get_ci_repo_name() resolves to dd-trace-go, but this new override map has no dd-trace-go entry, so all _Owner.injection_platform feature markers still fall back to @DataDog/injection-platform. I checked the Go manifest and injection-platform-covered tests are active there, including auto-inject AppSec and Docker SSI entries (manifests/golang.yml:819-821, manifests/golang.yml:874), so those Go results remain attributed to the old default instead of the Go language-platform owner used by the adjacent language_platform mapping.
Useful? React with 👍 / 👎.
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 49bbf97 | Docs | Datadog PR Page | Give us feedback! |
pierotibou
left a comment
pierotibou
left a comment
There was a problem hiding this comment.
But as discussed in Slack, we need more than that if we're asking more ownership, we will need to work with LP on the details, the trainings, because they haven't effectively done it indeed.
| injection_platform = _OwnerDef("@DataDog/injection-platform", repo_overrides={ | ||
| "dd-trace-dotnet": "@DataDog/apm-lang-platform-dotnet", | ||
| "dd-trace-java": "@DataDog/apm-lang-platform-java", | ||
| "dd-trace-js": "@DataDog/lang-platform-js", | ||
| "dd-trace-php": "@DataDog/apm-lang-platform-php", | ||
| "dd-trace-py": "@DataDog/lang-platform-python", | ||
| "dd-trace-rb": "@DataDog/lang-platform-ruby", | ||
| }) |
There was a problem hiding this comment.
Go isn't in SSI scope yet
Totally agree. Let’s see whether the CI root-cause analysis tool we’re building this quarter helps with the initial triage. Then, for next quarter, we should plan some improvements to these tests and training for the teams. |
Motivation
Adds per-repository owner overrides to the injection_platform owner definition in utils/_features.py. Previously, all injection_platform features defaulted to @DataDog/injection-platform as the owner across all tracer repositories. This change routes ownership to the appropriate language-platform teams when the feature is evaluated in a specific tracer repo context.
The injection_platform feature category covers work that is ultimately implemented by language-specific platform teams in each tracer library. Having a single owner for all repos meant the wrong team was notified/attributed for those features. This aligns the owner definitions with the same pattern already used by language_platform.
Changes
utils/_features.py: Added repo_overrides to injection_platform mapping each tracer repo to its owning language-platform team:
dd-trace-dotnet → @DataDog/apm-lang-platform-dotnet
dd-trace-java → @DataDog/apm-lang-platform-java
dd-trace-js → @DataDog/lang-platform-js
dd-trace-php → @DataDog/apm-lang-platform-php
dd-trace-py → @DataDog/lang-platform-python
dd-trace-rb → @DataDog/lang-platform-ruby
Workflow
🚀 Once your PR is reviewed and the CI green, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
tests/ormanifests/is modified ? I have the approval from R&P teambuild-XXX-imagelabel is present