RUM-17613 Rename Timeseries abstractions to TimeseriesCollector - #3711
RUM-17613 Rename Timeseries abstractions to TimeseriesCollector#3711satween wants to merge 1 commit into
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
🎉 All green!🧪 All tests passed 🔄 Datadog auto-retried 2 jobs - 2 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: a90a51b | Docs | Datadog PR Page | Give us feedback! |
Rename the internal Timeseries interface to TimeseriesCollector and rename its implementations to DefaultTimeseriesCollector and DefaultTimeseriesCollectorFactory, propagating the new names through RumFeature, the RUM scope tree and the tests. No behaviour change. Ref: RUM-17613
212abc3 to
a90a51b
Compare
satween
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/timeseries #3711 +/- ##
======================================================
+ Coverage 73.21% 73.23% +0.02%
======================================================
Files 1011 1011
Lines 36859 36859
Branches 6368 6368
======================================================
+ Hits 26985 26991 +6
+ Misses 8045 8039 -6
Partials 1829 1829
🚀 New features to boost your workflow:
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a90a51b806
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - "java.util.concurrent.atomic.AtomicReference.compareAndSet(com.datadog.android.flags.internal.repository.DefaultFlagsRepository.FlagsState?, com.datadog.android.flags.internal.repository.DefaultFlagsRepository.FlagsState?)" | ||
| - "java.util.concurrent.atomic.AtomicReference.compareAndSet(com.datadog.trace.bootstrap.instrumentation.api.AgentTracer.TracerAPI?, com.datadog.trace.bootstrap.instrumentation.api.AgentTracer.TracerAPI?)" | ||
| - "java.util.concurrent.atomic.AtomicReference.compareAndSet(com.datadog.android.rum.internal.timeseries.RumSessionScopeTimeseries.State?, com.datadog.android.rum.internal.timeseries.RumSessionScopeTimeseries.State?)" | ||
| - "java.util.concurrent.atomic.AtomicReference.compareAndSet(com.datadog.android.rum.internal.timeseries.DefaultTimeseriesCollector.State?, com.datadog.android.rum.internal.timeseries.DefaultTimeseriesCollector.State?)" |
There was a problem hiding this comment.
The reviewed commit is unsigned: git show -s --format=%G? 5aef636d2e5e7240ab14ad154f527f54489974af returns N. Recreate this commit with a valid GPG signature before merging to satisfy the repository policy.
AGENTS.md reference: AGENTS.md:L115-L118
Useful? React with 👍 / 👎.
| insightsCollector = rumFeature.insightsCollector, | ||
| heatmapIdentifierRegistry = rumFeature.heatmapIdentifierRegistry, | ||
| timeseriesFactory = rumFeature.timeseriesFactory | ||
| timeseriesCollectorFactory = rumFeature.timeseriesCollectorFactory |
There was a problem hiding this comment.
This commit is titled RUM-17613 Rename Timeseries abstractions to TimeseriesCollector, but repository policy requires the exact RUM-XXXXX: <short description> format. Change it to RUM-17613: Rename Timeseries abstractions to TimeseriesCollector before merging.
AGENTS.md reference: AGENTS.md:L115-L120
Useful? React with 👍 / 👎.
2 participants
What does this PR do?
Renames the internal
Timeseriesinterface toTimeseriesCollector,RumSessionScopeTimeseriestoDefaultTimeseriesCollectorandRumSessionScopeTimeseriesFactorytoDefaultTimeseriesCollectorFactory, propagating the names throughRumFeature,Rum,RumApplicationScope,RumSessionScope,DatadogRumMonitor(stopActiveTimeseries()->stopTimeseries()) and the matching tests. No behaviour change, no public API change.Motivation
First PR of a 3-PR stack. Isolating the rename keeps the follow-up schema PR's diff about the
schema instead of about naming.
Additional Notes
NoOpTimeseriesCollector/NoOpTimeseriesCollectorFactoryare KSP-generated from the renamed interface.The detekt safe-call entries for
AtomicReference<RumSessionScopeTimeseries.State>are renamedhere and removed in the next PR, where the
AtomicReferencegoes away.api/apiSurfaceandapi/dd-sdk-android-rum.apiare unchanged (all renamed symbols areinternal), verified by re-runninggenerateApiSurface+apiDump.DatadogRumMonitorTestgains one test covering the renamedstopTimeseries().Review checklist (to be filled by reviewers)
Ref: RUM-17613