feat: add post filter for holes and floors#681
Open
sseu-buhzzi wants to merge 81 commits into
Open
Conversation
sseu-buhzzi
changed the title
Contributor
Author
One problem is that buttons are now too many in the forum page. I am not sure where this new filter button should go. |
This commit also introduced a `WithPostFilterBar` widget to wrap the page body and deduplicate the build logic.
Member
|
Sorry for late reply. The idea LGTM, but maybe the search toolbar is too hard-core for average users? 🤔 I'm considering an "easy mode", which allows user to select filters (e.g., Also, you might want to support showing a dropdown filter history list in the text field, like the post searching page we have currently, so that user doesn't need to input the same filter again and again. |
Big Pickle did these when refactoring the boolean expr rows. I do not know the reason, but the UI for array and map would be designed again later.
Each slot is always bound to the parent group, which makes the expr it holds easy to operate with.
…ching the condition selectors
sseu-buhzzi
force-pushed
the
20260611/feat-post-filter
branch
from
c3c91bc to
9571a0f
Compare
Contributor
Author
|
User friendly UI selectors are like: History and UI restoring are like: |
…tered This prevents scroll jitter when many pages are filtered out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #680.