industry_standard/spdm: Add SLOT_MANAGEMENT definitions - #3670
Open
jyao1 wants to merge 1 commit into
Open
Conversation
Add the SPDM 1.4 SLOT_MANAGEMENT / SLOT_MANAGEMENT_RESP request and response structures, the SubCode value defines, the SLOT_MGMT_CAP extended capability flag, the SPDM_MAX_BANK_COUNT define (BankID is 0 to 239), and the SubCode-dependent structures for all defined SubCodes: SupportedSubCodes, SlotAddress, BankInfo/BankElement, BankDetails/SlotElement, GetCertificateChain, ManageBank, ManageSlot, GetCSR, CSR, and SetCertificate. Signed-off-by: Jiewen Yao <jiewen.yao@intel.com> Assisted-by: Claude Code:claude-opus-4-8
alistair23
suggested changes
Jun 30, 2026
| spdm_slot_management_slot_address_struct_t slot_address; | ||
| uint32_t cert_length; | ||
| uint8_t cert_attributes; | ||
| uint8_t key_pair_id; |
Contributor
There was a problem hiding this comment.
What version of the spec has this? https://www.dmtf.org/sites/default/files/standards/documents/DSP0274_1.4.0.pdf pg. 250 doesn't show key_pair_id
alistair23
reviewed
Jun 30, 2026
| uint8_t operation; | ||
| uint8_t reserved[3]; | ||
| uint32_t select_asym_algo; | ||
| /* uint8_t select_pqc_asym_algo_len; |
Contributor
There was a problem hiding this comment.
Does this need to be commented out?
| uint32_t asym_algo_capabilities; | ||
| uint32_t current_asym_algo; | ||
| uint32_t available_asym_algo; | ||
| /* uint8_t pqc_asym_algo_cap_len; |
Contributor
There was a problem hiding this comment.
Same comment here about commenting out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the SPDM 1.4 SLOT_MANAGEMENT / SLOT_MANAGEMENT_RESP request and response structures, the SubCode value defines, the SLOT_MGMT_CAP extended capability flag, the SPDM_MAX_BANK_COUNT define (BankID is 0 to 239), and the SubCode-dependent structures for all defined SubCodes: SupportedSubCodes, SlotAddress, BankInfo/BankElement, BankDetails/SlotElement, GetCertificateChain, ManageBank, ManageSlot, GetCSR, CSR, and SetCertificate.
Assisted-by: Claude Code:claude-opus-4-8